Skip to content

Comments

Pr review quick wins#143

Merged
Transurgeon merged 3 commits intocvxpy-mergefrom
pr-review-quick-wins
Feb 3, 2026
Merged

Pr review quick wins#143
Transurgeon merged 3 commits intocvxpy-mergefrom
pr-review-quick-wins

Conversation

@Transurgeon
Copy link
Member

@Transurgeon Transurgeon commented Feb 3, 2026

Description

Please include a short summary of the change.
Issue link (if applicable):

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

Transurgeon and others added 3 commits February 2, 2026 19:27
@Transurgeon @claude
Update diff_engine_core to v0.1.1 (#142)
7919d4d 
Includes:
- Fix Windows build (#41)
- Remove Python bindings (moved to DNLP repository) (#40)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
@Transurgeon
Merge remote-tracking branch 'origin/master' into cvxpy-merge
3f29074
@Transurgeon @claude
Address PR cvxpy#3108 review: quick fixes
ef80721 
- Fix indentation in ipopt_nlpif.py cyipopt.Problem() constructor
- Fix typo in problem.py docstring ("value ofro" -> "value of")
- Rename Dnlp2Smooth to DNLP2Smooth for consistency with DGP2DCP/DQCP2DCP
- Fix pnorm ESR condition: p >= 1 (was p > 1)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@Transurgeon Transurgeon merged commit 4b8d0f9 into cvxpy-merge Feb 3, 2026
19 of 20 checks passed
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Benchmarks that have stayed the same:

   before           after         ratio
 [4b8d0f9e]       [45e8d150]
      492±0ms          525±0ms     1.07  semidefinite_programming.SemidefiniteProgramming.time_compile_problem
     14.6±0ms         15.3±0ms     1.05  simple_QP_benchmarks.ParametrizedQPBenchmark.time_compile_problem
      1.35±0s          1.37±0s     1.01  matrix_stuffing.ParamConeMatrixStuffing.time_compile_problem
      13.1±0s          13.3±0s     1.01  finance.CVaRBenchmark.time_compile_problem
      232±0ms          235±0ms     1.01  gini_portfolio.Murray.time_compile_problem
      4.28±0s          4.32±0s     1.01  huber_regression.HuberRegression.time_compile_problem
      317±0ms          319±0ms     1.01  gini_portfolio.Yitzhaki.time_compile_problem
      1.59±0s          1.60±0s     1.00  tv_inpainting.TvInpainting.time_compile_problem
      682±0ms          683±0ms     1.00  matrix_stuffing.ConeMatrixStuffingBench.time_compile_problem
     38.3±0ms         38.4±0ms     1.00  matrix_stuffing.SmallMatrixStuffing.time_compile_problem
      953±0ms          954±0ms     1.00  gini_portfolio.Cajas.time_compile_problem
      237±0ms          238±0ms     1.00  simple_QP_benchmarks.SimpleQPBenchmark.time_compile_problem
      22.4±0s          22.4±0s     1.00  sdp_segfault_1132_benchmark.SDPSegfault1132Benchmark.time_compile_problem
      1.86±0s          1.86±0s     1.00  simple_QP_benchmarks.UnconstrainedQP.time_compile_problem
      890±0ms          890±0ms     1.00  simple_LP_benchmarks.SimpleScalarParametrizedLPBenchmark.time_compile_problem
      145±0ms          145±0ms     1.00  high_dim_convex_plasticity.ConvexPlasticity.time_compile_problem
      274±0ms          274±0ms     1.00  matrix_stuffing.ParamSmallMatrixStuffing.time_compile_problem
      5.03±0s          5.02±0s     1.00  optimal_advertising.OptimalAdvertising.time_compile_problem
      4.96±0s          4.95±0s     1.00  svm_l1_regularization.SVMWithL1Regularization.time_compile_problem
      2.95±0s          2.94±0s     1.00  quantum_hilbert_matrix.QuantumHilbertMatrix.time_compile_problem
      280±0ms          279±0ms     0.99  slow_pruning_1668_benchmark.SlowPruningBenchmark.time_compile_problem
      840±0ms          830±0ms     0.99  simple_QP_benchmarks.LeastSquares.time_compile_problem
      1.04±0s          1.03±0s     0.99  finance.FactorCovarianceModel.time_compile_problem
      11.3±0s          11.1±0s     0.98  simple_LP_benchmarks.SimpleLPBenchmark.time_compile_problem
     14.3±0ms         14.0±0ms     0.98  simple_LP_benchmarks.SimpleFullyParametrizedLPBenchmark.time_compile_problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Transurgeon